Repository navigation
feat: add simulation-owned environmental skill impacts - #129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hoainho
left a comment
There was a problem hiding this comment.
Main-session acceptance review complete for #128: no open blocking findings within this change. Reviewed offensive resolution -> fixed-step material/impulse state -> native projection; actor/camera/quest/support authority remains separate. Repairs include force-query sampling cost, airborne zero-speed apex, settling/angular tails, support-removal wake and protected route visual IDs. Observed 143 integration tests, 236 release-validator unit tests, final production build and 15 finite REA native assertions passing. These are not asset release/FPS certification or global REA trace equality. The Vercel preview reports Ready, but browser access is SSO-protected; no preview UI success is claimed. This is the coordinating session review, not an independent model approval.
|
Post-merge acceptance for
|
Scope
Closes #128.
Observed validation
bun run build: TypeScript and Vite passed; existing large-chunk warning remains.node --test tests/release/*.test.mjs: 236 pass, 0 fail, 0 skipped. Validator unit success does not certify candidate native assets for release.Evidence and review
Captured transitions, source hashes, native screenshots and limits. Combat contract.
Spec and implementation review performed in the main coordinating session under the current coordinator-owned review policy; no independent model review is claimed.
Limits
This is bounded local prop response, not terrain deformation, mesh fracture, tree uprooting, loose-body-to-loose-body collision or a whole-roster native art/FPS certification. Campaign Continue keeps its safe-checkpoint policy; no permanent destruction world facts or save-format migration. Kena/Zenless Zone Zero remain historical visual references, not REA-decompiled commercial binaries. REA observed the shipped Last Stand/Three.js graph and controlled our native replay; no commercial destruction algorithm is inferred. REA retained every requested step/image/DOM but reports an events-completeness mismatch (also when events were omitted); tool issue filed and no global trace-equality certification claimed.