Skip to content

Overhaul School Vocabulary Manager - #9608

Draft
michaelchadwick wants to merge 1 commit into
ilios:masterfrom
michaelchadwick:frontend-6927-school-vocab-manager-overhaul
Draft

michaelchadwick wants to merge 1 commit into
ilios:masterfrom
michaelchadwick:frontend-6927-school-vocab-manager-overhaul

Conversation

@michaelchadwick

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#6927

The current School Vocabulary Manager needed an overhaul and that's what this PR does.

  • Change the view of terms to use the same tree-style view as the TaxonomyManager used when adding terms to Courses, Sessions, etc.
  • Top-level terms are still added using the conventional form but it is now hidden behind a toggle
  • Move the forms for adding and editing terms into the list item
  • Added Ilios-standard deletion trash can and confirmation protection
  • Could not find a better icon to indicate "add sub-term", so + will have to do for now
  • Full suite of integration tests
  • Claude helped with the initial push to get stuff going, but plenty of manual changes were done by this human, and most code was probably updated or expanded since then

The Taxonomy Manager could probably use some updates, like adding term counts, but that's a separate PR.

Old
Screenshot 2026-10-07 at 5 49 22 PM

Bold
Screenshot 2026-10-07 at 5 49 17 PM

@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit a0d6c41
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6ad13ff34c72d9e1f7048617
😎 Deploy Preview https://deploy-preview-9608--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

✅ Visual Diff Report — PASSED

2160 images compared: 2160 identical

Download the results.

@michaelchadwick michaelchadwick added the approve visual diff Manually Approve the Results of a Visual Diff Run label Oct 8, 2026
@michaelchadwick
michaelchadwick force-pushed the frontend-6927-school-vocab-manager-overhaul branch from bebf909 to 6062c2e Compare October 8, 2026 16:10
@github-actions github-actions Bot removed the approve visual diff Manually Approve the Results of a Visual Diff Run label Oct 8, 2026
@saschaben

saschaben commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

I'm liking the progress! Two quick notes after a cursory review:

First - can we get a "add new (top-level) term" tooltip for the big add (+) icon, similar to what we have for the individual sub-term add icons?
second - while we are on sub-terms...what if we were to move the add sub-term function to the edit screen of the term itself? I know we touched on top-level accessibility for this, but in this iteration I think it is clear that having the full display, along with the one-level edit tool, AND right next to it the add a sub-level tool, gets a bit busy and unintuitive. Moving the sub-term add into the term edit screen might make more intuitive sense now.

@michaelchadwick

Copy link
Copy Markdown
Contributor Author

Todo:

  • Remove "Title:"
  • Add tooltip to top-level term +
  • Move filter to right-side, make smaller
  • Clicking the highlighted row will trigger edit form
  • Hide new sub term icon unless in the edit form to de-emphasize it
  • Try making icons larger when in edit form mode

@michaelchadwick
michaelchadwick force-pushed the frontend-6927-school-vocab-manager-overhaul branch 7 times, most recently from 7c3a69f to 239b5a5 Compare October 15, 2026 20:27
@michaelchadwick
michaelchadwick force-pushed the frontend-6927-school-vocab-manager-overhaul branch from 239b5a5 to a0d6c41 Compare October 15, 2026 21:04
@michaelchadwick
michaelchadwick marked this pull request as ready for review October 15, 2026 22:06
@michaelchadwick
michaelchadwick marked this pull request as draft October 15, 2026 22:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[meta] overhaul school vocabulary term management interface

2 participants