Skip to content

Add missing UserProfile headers - #9583

Merged
jrjohnson merged 5 commits into
ilios:masterfrom
michaelchadwick:frontend-7466-add-missing-user-profile-headers
Oct 11, 2026
Merged

jrjohnson merged 5 commits into
ilios:masterfrom
michaelchadwick:frontend-7466-add-missing-user-profile-headers

Conversation

@michaelchadwick

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#7466

Adds "Biography" and "Roles" headers to the appropriate sections of a user profile.

@netlify

netlify Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 7338d34
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6ac97c0267d5080008e02460
😎 Deploy Preview https://deploy-preview-9583--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

✅ Visual Diff Approved

❌ Visual Diff Report — FAILED

2160 images compared: 77 different · 2083 identical

Details

Differences (77)

File Diff % Notes
desktop-Acceptance _ Course - Session List_expand all sessions_expanded_dark.png 0.01%
desktop-Acceptance _ Course - Session List_expand all sessions_not expanded_dark.png 0.07%
desktop-Acceptance _ My Profile_Non Student Theme Chooser__dark.png 100.00% ⚠️ Dimension mismatch (1101x1000, Data length: 4404000 → 1057x1000, Data length: 4228000)
desktop-Acceptance _ My Profile_Non Student Theme Chooser__light.png 100.00% ⚠️ Dimension mismatch (1101x1000, Data length: 4404000 → 1057x1000, Data length: 4228000)
desktop-Acceptance _ My Profile_Student Theme Chooser__dark.png 100.00% ⚠️ Dimension mismatch (1070x1000, Data length: 4280000 → 1029x1000, Data length: 4116000)
desktop-Acceptance _ My Profile_Student Theme Chooser__light.png 100.00% ⚠️ Dimension mismatch (1070x1000, Data length: 4280000 → 1029x1000, Data length: 4116000)
desktop-Acceptance _ User_can search for users_default_dark.png 100.00% ⚠️ Dimension mismatch (939x1000, Data length: 3756000 → 937x1000, Data length: 3748000)
desktop-Acceptance _ User_can search for users_default_light.png 100.00% ⚠️ Dimension mismatch (939x1000, Data length: 3756000 → 937x1000, Data length: 3748000)
desktop-Acceptance _ User_can search for users_search results dropdown_dark.png 100.00% ⚠️ Dimension mismatch (939x1000, Data length: 3756000 → 937x1000, Data length: 3748000)
desktop-Acceptance _ User_can search for users_search results dropdown_light.png 100.00% ⚠️ Dimension mismatch (939x1000, Data length: 3756000 → 937x1000, Data length: 3748000)
desktop-Acceptance _ User_permissions view #7048__dark.png 100.00% ⚠️ Dimension mismatch (627x1000, Data length: 2508000 → 621x1000, Data length: 2484000)
desktop-Acceptance _ User_permissions view #7048__light.png 100.00% ⚠️ Dimension mismatch (627x1000, Data length: 2508000 → 621x1000, Data length: 2484000)
desktop-Acceptance _ User_User roles display_user1 manage roles_dark.png 100.00% ⚠️ Dimension mismatch (944x1000, Data length: 3776000 → 932x1000, Data length: 3728000)
desktop-Acceptance _ User_User roles display_user1 manage roles_light.png 100.00% ⚠️ Dimension mismatch (944x1000, Data length: 3776000 → 932x1000, Data length: 3728000)
desktop-Acceptance _ User_User roles display_user1_dark.png 100.00% ⚠️ Dimension mismatch (944x1000, Data length: 3776000 → 932x1000, Data length: 3728000)
desktop-Acceptance _ User_User roles display_user1_light.png 100.00% ⚠️ Dimension mismatch (944x1000, Data length: 3776000 → 932x1000, Data length: 3728000)
desktop-Acceptance _ User_User roles display_user2 manage roles_dark.png 100.00% ⚠️ Dimension mismatch (959x1000, Data length: 3836000 → 946x1000, Data length: 3784000)
desktop-Acceptance _ User_User roles display_user2 manage roles_light.png 100.00% ⚠️ Dimension mismatch (959x1000, Data length: 3836000 → 946x1000, Data length: 3784000)
desktop-Acceptance _ User_User roles display_user2_dark.png 100.00% ⚠️ Dimension mismatch (959x1000, Data length: 3836000 → 946x1000, Data length: 3784000)
desktop-Acceptance _ User_User roles display_user2_light.png 100.00% ⚠️ Dimension mismatch (959x1000, Data length: 3836000 → 946x1000, Data length: 3784000)
laptop-Acceptance _ Course - Session List_expand all sessions_expanded_dark.png 0.01%
laptop-Acceptance _ Course - Session List_expand all sessions_not expanded_dark.png 0.06%
laptop-Acceptance _ My Profile_Non Student Theme Chooser__dark.png 100.00% ⚠️ Dimension mismatch (1053x1000, Data length: 4212000 → 1011x1000, Data length: 4044000)
laptop-Acceptance _ My Profile_Non Student Theme Chooser__light.png 100.00% ⚠️ Dimension mismatch (1053x1000, Data length: 4212000 → 1011x1000, Data length: 4044000)
laptop-Acceptance _ My Profile_Student Theme Chooser__dark.png 100.00% ⚠️ Dimension mismatch (1029x1000, Data length: 4116000 → 989x1000, Data length: 3956000)
… and 52 more

Download the results.

@michaelchadwick michaelchadwick added the approve visual diff Manually Approve the Results of a Visual Diff Run label Sep 29, 2026
@jrjohnson

Copy link
Copy Markdown
Member

I don't have any better ideas, but marking NTD so we can talk about Biography - doesn't feel quite right.

@michaelchadwick

Copy link
Copy Markdown
Contributor Author

@jrjohnson Details?

@dartajax

dartajax commented Oct 5, 2026

Copy link
Copy Markdown
Member

I tend to go with "Overview" but we don't want to repeat something out of context so let's discuss.

@michaelchadwick

Copy link
Copy Markdown
Contributor Author

NTS: Change Bio to Profile

@michaelchadwick
michaelchadwick force-pushed the frontend-7466-add-missing-user-profile-headers branch from 6e70fe0 to 01ffc4f Compare October 6, 2026 18:02
@github-actions github-actions Bot removed the approve visual diff Manually Approve the Results of a Visual Diff Run label Oct 6, 2026
@michaelchadwick
michaelchadwick force-pushed the frontend-7466-add-missing-user-profile-headers branch from 01ffc4f to 7338d34 Compare October 9, 2026 23:42
@michaelchadwick michaelchadwick added the approve visual diff Manually Approve the Results of a Visual Diff Run label Oct 10, 2026
@jrjohnson
jrjohnson merged commit 1ddc4bd into ilios:master Oct 11, 2026
40 of 41 checks passed
@michaelchadwick
michaelchadwick deleted the frontend-7466-add-missing-user-profile-headers branch October 15, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve visual diff Manually Approve the Results of a Visual Diff Run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserProfile->Bio and UserProfile->Roles need headers

3 participants