Remove restrictions on operations; Numpy already has them built in#1
Open
298A-E9E3 wants to merge 1 commit into
Open
Remove restrictions on operations; Numpy already has them built in#1298A-E9E3 wants to merge 1 commit into
298A-E9E3 wants to merge 1 commit into
Conversation
This will allow for all operations to function on scalars and vectors
Owner
|
I'd prefer the error handling to be at the level of the library itself. NumPy would show The checks using the unions are a bit less verbose but would crash on python versions 3.6 to 3.9, I'd rather have the compatibility. The addition of Apply those changes and I'd gladly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow for all operations to function on scalars and vectors