Resolve upstream conflicts and harden FunASR S3 handling - #1
Closed
LauraGPT wants to merge 2 commits into
Closed
Conversation
|
Thank you for your contribution! By submitting this pull request, you agree to the terms of our Contributor License Agreement (CLA). Key points:
If you have any questions about the CLA, please let us know! |
4 tasks
Owner
|
Closing — merged the useful changes directly into pr/funasr-connector with Aliyun OSS compat and intranet S3 endpoint preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This collaboration PR prepares murtaza-nasir#353 for another upstream review.
Changes:
Validation:
The one full-suite warning is an existing SQLAlchemy test-cleanup warning in tests/test_api_v1_users_me.py.