Fix missing capital letter detection for input, added tests - #35
Conversation
|
how to make merge to staging instead of main |
YetAnotherMechanicusEnjoyer
left a comment
There was a problem hiding this comment.
Approved, but you could pass in ui::error::render() an anyhow::Error instead of &str so you don't have to parse the String
it was during pull request creation, you could choose the branch. Now that it's created idk if you can change it Edit: Well I found lol |
i will fix then at the train |
That would be nice ! |
|
Okay I'm looking at it, and i think this error stuff probably makes more sense in a different pull request since those commits were already there before the pull request. Basically the string comes from AppState:Error(String), and validate_token() constructs it through Result<ApiClient, String>. So I guess my point is that it might make more sense to make it Anyhow for the entire time (or have our own error wrapper, personally would prefer that) |
Resolves #25
I also added a GoToTop action just so we can simulate multiple key bindings for the tests