Skip to content

Fix missing capital letter detection for input, added tests - #35

Merged
ih8js-git merged 3 commits into
stagingfrom
test/input
Jul 18, 2026
Merged

Fix missing capital letter detection for input, added tests #35
ih8js-git merged 3 commits into
stagingfrom
test/input

Conversation

@thairanaru

Copy link
Copy Markdown
Collaborator

Resolves #25
I also added a GoToTop action just so we can simulate multiple key bindings for the tests

@thairanaru

Copy link
Copy Markdown
Collaborator Author

how to make merge to staging instead of main

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but you could pass in ui::error::render() an anyhow::Error instead of &str so you don't have to parse the String

@YetAnotherMechanicusEnjoyer

YetAnotherMechanicusEnjoyer commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

how to make merge to staging instead of main

it was during pull request creation, you could choose the branch. Now that it's created idk if you can change it

Edit: Well I found lol

@thairanaru

Copy link
Copy Markdown
Collaborator Author

Approved, but you could pass in ui::error::render() an anyhow::Error instead of &str so you don't have to parse the String

i will fix then at the train

@YetAnotherMechanicusEnjoyer

Copy link
Copy Markdown
Collaborator

Approved, but you could pass in ui::error::render() an anyhow::Error instead of &str so you don't have to parse the String

i will fix then at the train

That would be nice !

@thairanaru

thairanaru commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Okay I'm looking at it, and i think this error stuff probably makes more sense in a different pull request since those commits were already there before the pull request.

Basically the string comes from AppState:Error(String), and validate_token() constructs it through Result<ApiClient, String>. So I guess my point is that it might make more sense to make it Anyhow for the entire time (or have our own error wrapper, personally would prefer that)

@ih8js-git
ih8js-git merged commit b1ad7b1 into staging Jul 18, 2026
2 of 3 checks passed
@ih8js-git
ih8js-git deleted the test/input branch July 18, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for src/input.rs

3 participants