Repository navigation
Conversation
|
Reviewed against the HER Hack-Astron #4 acceptance criteria (comment only — winner selection stays with @FenjuFu). Verified
Notes
Valid entry. |
|
复核当前 HEAD 0bfd676 后,暂不能 approve,仍有以下阻塞项:
请补齐实际可运行的源码与依赖(或提供固定到具体 commit 的公开源码,并确保命令可直接复现)、真实推理原始产物及指标计算材料,同时修复全部提交的 DCO。完成后可再次复审。 |
Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
Add all source files (src/) and evidence (evidence/) to enable full reproduction: - MCP Server: test_server.py, server.py, backend.py, slots.py - Auth & Risk: auth_middleware.py, home_risk_engine.py, ha_adapter.py - Insurance & Demo: insurance_api.py, demo_2035_scenario.py - Evidence: run logs, 50 inference results, sqlite snapshots Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
0bfd676 to
9e275dc
Compare
|
Hi @FenjuFu, all three blocking items have been addressed:
Please review when you get a chance. Thanks! |
|
复核当前 HEAD 但对照 #20 的硬性验收标准,目前仍不能 approve,阻塞项如下:
另有一个可移植性问题:README 的直接复现命令在 Windows 默认 GBK 控制台会因 emoji 触发 修正以上内容后可再次复审。DCO/CLA 当前无需再处理。 |
…al script, run_logs evidence - insurance_api.py: bearer-only auth (no query token), sanitized log_message, add log-no-token regression test (18/18) - eval/run_eval_transformers.py: reproducible HF fixed-revision eval (5x10, warmup, latency, compliance) - README: Windows UTF-8 note, eval script command, evidence scope clarification - evidence/run_logs: multi-run auth.db + insurance.db snapshots (redacted demo data) Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
Signed-off-by: Kencoze <Kencoze@users.noreply.github.com>
FenjuFu
left a comment
There was a problem hiding this comment.
Re-reviewed current head 43c77bfc against the hard acceptance criteria in #20. The source files, DCO/CLA, run snapshots, token-log sanitization, Windows UTF-8 note, and an evaluation script/notebook have now been added. Those earlier gaps are acknowledged as fixed.
The real-model evidence is still blocking approval:
-
evidence/domux_eval_result_20260826_204027.jsonstill identifies the model asiFlytekOpenSource/Domux (via ModelScope)and is dated 2026-08-26. It does not contain the pinned Hugging Face revision,warmup_count, or generation metadata produced by the new evaluator. The Hugging Face evaluator and the README claim were added on 2026-09-03, so the committed evidence could not have been generated by that path. Please actually rerun from Hugging Face revision6c71a32f4d624cadfd9fce9d10240d8068e53456and replace the artifact with the generated result; changing metadata text alone would not satisfy the requirement. -
The new script records the literal placeholder
transformers (from transformers import version)instead of the installed Transformers version. The regenerated evidence should record the real Transformers, Torch/CUDA, tokenizer/model revision, GPU, precision, dataset source, and whether the fallback set was used. -
The protocol is not currently frozen to the claimed 50 runs:
load_test_set()returns up to 200 items when either remote URL becomes available, while the README/docstring says 5×10 = 50. Also,format_valid()accepts any pipe output with at least five segments even though the documented Domux contract has seven fields. Please make the sample inventory deterministic and validate the actual seven-field contract (or document and justify another precise schema).
Until the committed evidence is generated by the documented Hugging Face path and the evaluator/report agree on sample count and metric definition, #20 criteria 1 (real use), 4 (reproducibility), and 5 (honest metrics) remain unmet.
|
Closing this for now since there's been no update since the last review on Sep 7. The remaining blocker for #20 is real-model evidence: the evaluation result still comes from ModelScope, without the pinned Hugging Face revision or the metadata produced by the evaluator in this PR. Happy to reopen once there's a run downloaded from the pinned Hugging Face revision. |
Domux MCP Server — 从解析模型升级为智能家居标准能力层
案例概要
把 Domux 从「一个 NL→结构化槽位的解析模型」封装为标准 MCP Server,叠加:
关键成果
HF Discussion
https://huggingface.co/iFlytekOpenSource/Domux/discussions/6
复现