Repository navigation
Conversation
versions-watch (#5) listed 22 entries of PLAN/07 §2 with newer releases. Each moves to the release current on 2026-10-23 (three are a step past the issue's list: vite 8.3.5, html-validate 11.17.0 and size-limit 14.3.0 came out after Monday's run), in the three places the issue names: - versions.json: all 22 entries. - PLAN/07 §2: the rows and their release dates, a dated "re-verified" note, and the qs row says what P1-06 made it: watched only, not shipped (buildQueryString() replaced it). §7 names Playwright 1.64. - The constraints. composer.json moves the ones that follow a row's minor: twig/twig ^3.30, doctrine/orm ^3.7, symfony/stimulus-bundle ^3.6 (runtime), phpunit/phpunit ^13.4, phpstan/phpstan ^2.3, rector/rector ^2.7 (dev). doctrine-bundle (^3.0), php-cs-fixer (^3.95), infection (^0.35) and framework-bundle (^7.4 || ^8.0) already admit the new patch releases. package.json pins exactly: @axe-core/playwright 4.14.0, @playwright/test 1.64.1, eslint 10.13.0, html-validate 11.17.0, jsdom 30.1.3, prettier 3.9.10, size-limit and @size-limit/file 14.3.0, stylelint 17.16.0, vite 8.3.5, vitest 5.0.5; package-lock.json moves only those and their own dependencies. doctrine/mongodb-odm-bundle and qs have no constraint here. Follow-ups of the bumps: - src/Resources/public/app.js is rebuilt: Vite 8.3's minifier writes some early returns as conditional expressions. Same behaviour; the size budget and the CSS contract hold. - bin/visual.sh takes the Playwright image from package.json, so the screenshots now come from mcr.microsoft.com/playwright:v1.64.1-noble; playwright.config.js names it. - README and UPGRADE.md state the raised Twig and ORM floors; CHANGELOG (Unreleased, Changed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nitials it shows (#5) axe-core 4.14 (the bump in the previous commit) enables label-content-name-mismatch by default, and it failed on every page of the demo, in every width and theme: the user menu's button showed the user's initials ("AD", aria-hidden) and was named by aria-label="admin", so the text it shows was not part of its name (WCAG 2.5.3 Label in Name; a speech user saying "click AD" reaches nothing). It was the rule's only node. The initials are now what they look like, the user's avatar: <span role="img" aria-label="{{ userName }}">, and the button drops its aria-label and takes its name from that image. A screen reader still hears the identifier ("admin, button, collapsed"); the rule no longer applies, since neither the button nor an image names itself over visible text. Nothing changes on screen: the 84 Chromium screenshot baselines match as they are. - standard_layout.html.twig, adminata_top_nav_menu_user_block; its comment says why. - tests-adminata/fixtures/js/*.html re-dumped (make js-fixtures): the seven pages carrying the user menu. - CHANGELOG (Unreleased, Fixed). Tests, in mcr.microsoft.com/playwright:v1.64.1-noble: the axe, autocomplete and html-validate specs on Chromium 375 and 1280 px (98 passed; before the change 84 axe cases failed on this one node), the screenshot spec on all three Chromium widths (84 passed). Vitest 281 passed; adminata-functional, -contract and -unit pass apart from DashboardPantherTest (no geckodriver here). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #5.
versions-watchreported 22 entries of PLAN/07 §2 with newer releases. Each one moves to the release that was current on 2026-10-23, in the three places the issue names. Three releases came out after Monday's watch run, so they go one step past the issue's table: vite 8.3.5 (8.3.4 in the issue), html-validate 11.17.0 (11.16.4) and size-limit 14.3.0 (14.2.0). I re-ran the watch's own comparison against Packagist and npm afterwards, and it reports nothing outdated.eaaa24a3fDependenciesversions.json: all 22 entries.qsrow now says what P1-06 made it: watched only, not shipped (buildQueryString()replaced it). §7 names Playwright 1.64.composer.json: raises the constraints that follow a row's minor version.twig/twig^3.30,doctrine/orm^3.7,symfony/stimulus-bundle^3.6phpunit/phpunit^13.4,phpstan/phpstan^2.3,rector/rector^2.7doctrine/doctrine-bundle(^3.0),php-cs-fixer(^3.95),infection(^0.35),framework-bundle(^7.4 || ^8.0).doctrine/mongodb-odm-bundleandqshave no constraint in this repo.package.json(exact pins) andpackage-lock.json: @axe-core/playwright 4.14.0, @playwright/test 1.64.1, eslint 10.13.0, html-validate 11.17.0, jsdom 30.1.3, prettier 3.9.10, size-limit + @size-limit/file 14.3.0, stylelint 17.16.0, vite 8.3.5, vitest 5.0.5. The lock file changes only these packages and their own dependencies.src/Resources/public/app.jsis rebuilt. Vite 8.3's minifier rewrites some early returns as conditional expressions. Behaviour is the same, and the size budget (86.2 of 100 kB) and the CSS contract still pass.bin/visual.shreads the Playwright image tag frompackage.json, so screenshots now come frommcr.microsoft.com/playwright:v1.64.1-noble.playwright.config.jsnames that image.[Unreleased]→### Changed.1ee2e5cfcUser menu: the button is named by its avatar. axe-core 4.14 turns onlabel-content-name-mismatchby default, and it failed on every page, width and theme. It flagged one element: the user menu button. The button shows the initials ("AD",aria-hidden), but its name came fromaria-label="admin", so its visible text was not part of its name (WCAG 2.5.3 Label in Name). Now the initials are an avatar image,<span role="img" aria-label="{{ userName }}">, and the button takes its name from it without anaria-labelof its own. A screen reader still hears "admin, button". Nothing changes on screen: all 84 screenshot baselines match unchanged. The JS fixtures are re-dumped (7 pages), and CHANGELOG### Fixedhas an entry.Contract
aria-labelon its toggle button, which was never a markup hook (nothing in PHP, JS or the tests selects on it). The name is now carried by therole="img"span inside the button.npm run check:jqueryandmake check-namesare clean.idct/adminata-admin-mongodb-bundle: its unit suite against this checkout (mongo-compat) is green on this PR.Gates
Local (2-core machine):
make lint-php(both configs),make lint-composer(validate + normalize),php bin/check-upstream-versions.php,make check-names,make lint-symfony(container, twig, xliff, yaml): clean.package-lock.json): eslint, stylelint,css:layers, prettier,check:jquery,fixture(11 Tailwind assumptions), Vitest 281/281,npm run build(git diffonlyapp.js, committed),css:contract,size: all pass.composer update= what CI'shighestinstalls, MySQL fromdocker-compose.yml): every suite gives 2638 tests, 0 failures, 29 errors. All 29 are environmental. 26 areDashboardPantherTest(no geckodriver here). 3 areDoctrineODMQuerySourceIteratorTest(no MongoDB on 27017). After the second commit,adminata-functional,contract,unitgive 323 tests with only the 26 Panther errors.v1.64.1-noblecontainer (bin/visual.sh), Chromium only:CI on this PR:
main.main'sQuality assurancerun fails the same way (scheduled 2026-10-23 05:12, 987f223), because CI installshighest, which already had phpstan 2.3 and rector 2.7 before this PR.assertEmpty/assertNotEmptyfrom strict-rules and unused$message/$previousExceptionMessage/foreach variables, mostly in inheritedtests/files.FlipAssertRectorflags the same 5 files:AdminHelper,AbstractBlockService,AddDependencyCallsCompilerPass,tests/Admin/AdminTest.phpandtests/DependencyInjection/ConfigurationTest.php. Its parallel workers also time out.Discovered
^3.28for 3.28.0,^3.4for 3.4.0,^3.6for 3.6.8) as "constraint =^minorof the PLAN/07 row". That raisesrequirefor users too. recomaty-panel'sdeveloplock has twig 3.28.0, doctrine/orm 3.6.8 and stimulus-bundle 3.4.0. Its owncomposer.jsondoesn't hold any of them back (doctrine/orm: ^3; it doesn't require the other two directly), but its nextcomposer update idct/adminataneeds--with-dependencies. If you'd rather keep the runtime floors and move only the dev ones, it is three lines incomposer.jsonplus README/UPGRADE.md/CHANGELOG.label-content-name-mismatchtofindings.jsonas debt (the axe ledger is{}today), or keep@axe-core/playwrightat 4.13. I chose the avatar pattern (role="img"+ name on the initials, as Fluent UI's Avatar does). It keeps the screen reader output the same and adds no debt.PLAN/05(vite/vitest/jsdom/qs),PLAN/08("Playwright 1.62") and PLAN/07 §3's samplecomposer.jsonstill show the versions they were written with. They are design records, and the issue names only §2, so I left them alone.Screenshots
No screenshots: only recomaty-panel can be shot here. The template change has no visible effect, and the repo's own 84 Chromium baselines (both themes, 375/768/1280 px) match without regeneration.
Changelog
[Unreleased]→### Changed→ "Requirements follow the current releases (2026-10-23, #5)";### Fixed→ "The user menu's button is named by its avatar (2026-10-23, #5)".After merge
recomaty-panel picks this up with
composer update idct/adminata --with-dependencies(twig 3.30, doctrine/orm 3.7, stimulus-bundle 3.6 come along).Work done, @bpacholek! ~Bober 🦫