pass empty ParameterList instead of null

Timur Kelman · Timur Kelman · commit 98cda07a66ff · 2024-07-29T10:44:13.000+02:00
diff --git a/CodeConverter/CSharp/CommonConversions.cs b/CodeConverter/CSharp/CommonConversions.cs
@@ -145,7 +145,7 @@ public bool ShouldPreferExplicitType(VBSyntax.ExpressionSyntax exp,
                     equalsValueClauseSyntax = null;
                 } else {
                     var returnBlock = SyntaxFactory.Block(SyntaxFactory.ReturnStatement(adjustedInitializerExpr));
-                    _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, null));
+                    _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, SyntaxFactory.ParameterList()));
                     equalsValueClauseSyntax = null;
                 }
             } else {
diff --git a/CodeConverter/CSharp/ValidSyntaxFactory.cs b/CodeConverter/CSharp/ValidSyntaxFactory.cs
@@ -83,7 +83,6 @@ public static MethodDeclarationSyntax CreateMethod(string newMethodName, TypeSyn
     {
         var modifiers = SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.StaticKeyword));
         var typeConstraints = SyntaxFactory.List<TypeParameterConstraintClauseSyntax>();
-        parameterList ??= SyntaxFactory.ParameterList();
 
         var methodAttrs = SyntaxFactory.List<AttributeListSyntax>();
 

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public bool ShouldPreferExplicitType(VBSyntax.ExpressionSyntax exp,`
`145`	`145`	`equalsValueClauseSyntax = null;`
`146`	`146`	`} else {`
`147`	`147`	`var returnBlock = SyntaxFactory.Block(SyntaxFactory.ReturnStatement(adjustedInitializerExpr));`
`148`		`- _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, null));`
	`148`	`+ _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, SyntaxFactory.ParameterList()));`
`149`	`149`	`equalsValueClauseSyntax = null;`
`150`	`150`	`}`
`151`	`151`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ public static MethodDeclarationSyntax CreateMethod(string newMethodName, TypeSyn`
`83`	`83`	`{`
`84`	`84`	`var modifiers = SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.StaticKeyword));`
`85`	`85`	`var typeConstraints = SyntaxFactory.List<TypeParameterConstraintClauseSyntax>();`
`86`		`- parameterList ??= SyntaxFactory.ParameterList();`
`87`	`86`
`88`	`87`	`var methodAttrs = SyntaxFactory.List<AttributeListSyntax>();`
`89`	`88`