Merge pull request #1125 from TymurGubayev/fix/RefFunctionCallArgument/1

Don't write back into a method call when it's ByRef argument

Author: GrahamTheCoder

CodeConverter/CSharp/ExpressionNodeVisitor.cs

@@ -1920,13 +1920,15 @@ private RefConversion NeedsVariableForArgument(VBasic.Syntax.ArgumentSyntax node
         RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)
         {
             var symbolInfo = GetSymbolInfoInDocument<ISymbol>(expression);
-            if (symbolInfo is IPropertySymbol propertySymbol
-            // a property in VB.NET code can be ReturnsByRef if it's defined in a C# assembly the VB.NET code references
-            && !propertySymbol.ReturnsByRef && !propertySymbol.ReturnsByRefReadonly) {
+            if (symbolInfo is IPropertySymbol { ReturnsByRef: false, ReturnsByRefReadonly: false } propertySymbol) {
+                // a property in VB.NET code can be ReturnsByRef if it's defined in a C# assembly the VB.NET code references
                 return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;
             }
             else if (symbolInfo is IFieldSymbol { IsConst: true } or ILocalSymbol { IsConst: true }) {
                 return RefConversion.PreAssigment;
+            } else if (symbolInfo is IMethodSymbol { ReturnsByRef: false, ReturnsByRefReadonly: false }) {
+                // a method in VB.NET code can be ReturnsByRef if it's defined in a C# assembly the VB.NET code references
+                return RefConversion.PreAssigment;
             }
 
             if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;

Tests/CSharp/MemberTests/MemberTests.cs

@@ -4203,6 +4203,30 @@ public void MS(ref string s)
 }");
     }
 
+    [Fact]
+    public async Task TestRefFunctionCallNoParenthesesArgumentAsync()
+    {
+        await TestConversionVisualBasicToCSharpAsync(
+            @"Class RefFunctionCallArgument
+    Sub S(ByRef o As Object)
+        S(GetI)
+    End Sub
+    Function GetI() As Integer : End Function
+End Class", @"
+internal partial class RefFunctionCallArgument
+{
+    public void S(ref object o)
+    {
+        object argo = GetI();
+        S(ref argo);
+    }
+    public int GetI()
+    {
+        return default;
+    }
+}");
+    }
+
     [Fact]
     public async Task TestMissingByRefArgumentWithNoExplicitDefaultValueAsync()
     {