Skip to content

Fix HashSet retain fn mut signature and make HashSet Iter pub - #93

Open
4r33x wants to merge 9 commits into
ibraheemdev:masterfrom
4r33x:master
Open

Fix HashSet retain fn mut signature and make HashSet Iter pub #93
4r33x wants to merge 9 commits into
ibraheemdev:masterfrom
4r33x:master

Conversation

@4r33x

@4r33x 4r33x commented Apr 9, 2026

Copy link
Copy Markdown

HashSet Iter struct is needed for NewType patterns

@ibraheemdev

Copy link
Copy Markdown
Owner

Ah, I meant to do this as part of #80. I think I would prefer making the map and set modules public as papaya::map and papaya::set, and exporting any specific types under their respective modules, i.e., map::{Iter, Keys, Values, OccupiedError, Compute, HashMapRef, HashMapBuilder} and set::{HashSetRef, HashSetBuilder, Iter}, to be consistent with the standard library. We could remove the duplicate imports from root (as a breaking change).

@4r33x

4r33x commented Apr 17, 2026

Copy link
Copy Markdown
Author

Rebased, made the map and set modules public, removed some map imports from the lib.rs, and addressed all Clippy lints (stable 1.94) in the tests except clippy::needless_range_loop

If you want, I can split clippy changes into separate PR

@4r33x

4r33x commented Jun 19, 2026

Copy link
Copy Markdown
Author

@ibraheemdev Could you take a look, please?

@ibraheemdev

Copy link
Copy Markdown
Owner

Sorry I've been on vacation for a little while, I'll try to get to this soon.

@ibraheemdev

ibraheemdev commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Sorry for the wait. I split out the HashSet::retain change into #101 because the module reorganization is a breaking change. Can we also remove HashMapBuilder,HashSetBuilder, HashMapRef, and HashSetRef from the root exports, now that they are exported from the submodules?

@4r33x

4r33x commented Aug 22, 2026

Copy link
Copy Markdown
Author

Removed, also bumped version to comply with CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants