Skip to content

feat(transitive-overlay): enable strict mode - #34

Closed
daniel-heppner-ibigroup wants to merge 20 commits into
strict-mode-toolingfrom
strict-mode-transitive-overlay
Closed

daniel-heppner-ibigroup wants to merge 20 commits into
strict-mode-toolingfrom
strict-mode-transitive-overlay

Conversation

@daniel-heppner-ibigroup

@daniel-heppner-ibigroup daniel-heppner-ibigroup commented Apr 28, 2026 •

Copy link
Copy Markdown

Enables TS strict mode and then fixes the related type issues.

This PR also touches types package to create a new TransitiveSegment type which we then use in this package.

let fromAnchor;
let toAnchor;
let fromAnchor: PositionAnchor = "top-left";
let toAnchor: PositionAnchor = "top-left";

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a reasonable default?

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner, thanks so much. Also a little worried here about the dependency chain but I guess we'll just be careful when merging?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work???

miles-grant-ibigroup and others added 13 commits June 25, 2026 10:01
…n-parsing

Fix core-utils location parsing
# [@opentripplanner/core-utils-v16.0.5](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/core-utils-v16.0.4...@opentripplanner/core-utils-v16.0.5) (2026-06-25)

### Bug Fixes

* avoid name with commas being parsed as coordinate ([ecf8ad7](opentripplanner@ecf8ad7))
* notify user when geocoder fails ([4fe586e](opentripplanner@4fe586e))
# [@opentripplanner/timetable-v1.0.1](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/timetable-v1.0.0...@opentripplanner/timetable-v1.0.1) (2026-06-26)

### Bug Fixes

* Add classnames to timetable table components ([ed2a006](opentripplanner@ed2a006))
…ling

Basic infrastructure to prepare for strict mode updates
…e deps

- Set TS compile target to es2020
- Remove dep hoisting, add pnpm-workspace.yaml config
- Add missing type dependencies to packages without strict-mode branches
- Fix husky setup
- Enable TypeScript strict mode
- Add TransitiveSegment type to @opentripplanner/types
- Make stop_name optional in TransitiveStop
- Add missing type dependencies
@daniel-heppner-ibigroup
daniel-heppner-ibigroup deleted the strict-mode-transitive-overlay branch July 2, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants