Repository navigation
feat(transitive-overlay): enable strict mode - #34
Closed
daniel-heppner-ibigroup wants to merge 20 commits into
Closed
daniel-heppner-ibigroup wants to merge 20 commits into
daniel-heppner-ibigroup wants to merge 20 commits into
Conversation
| let fromAnchor; | ||
| let toAnchor; | ||
| let fromAnchor: PositionAnchor = "top-left"; | ||
| let toAnchor: PositionAnchor = "top-left"; |
There was a problem hiding this comment.
is this a reasonable default?
daniel-heppner-ibigroup
force-pushed
the
strict-mode-tooling
branch
from
May 7, 2026 19:14
3764eff to
3c97830
Compare
miles-grant-ibigroup
approved these changes
Jun 11, 2026
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
This is much cleaner, thanks so much. Also a little worried here about the dependency chain but I guess we'll just be careful when merging?
There was a problem hiding this comment.
How did this ever work???
daniel-heppner-ibigroup
force-pushed
the
strict-mode-tooling
branch
from
June 25, 2026 13:35
47ea0c2 to
a992bc2
Compare
…n-parsing Fix core-utils location parsing
# [@opentripplanner/core-utils-v16.0.5](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/core-utils-v16.0.4...@opentripplanner/core-utils-v16.0.5) (2026-06-25) ### Bug Fixes * avoid name with commas being parsed as coordinate ([ecf8ad7](opentripplanner@ecf8ad7)) * notify user when geocoder fails ([4fe586e](opentripplanner@4fe586e))
…ge-tweaks Timetable package tweaks
# [@opentripplanner/timetable-v1.0.1](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/timetable-v1.0.0...@opentripplanner/timetable-v1.0.1) (2026-06-26) ### Bug Fixes * Add classnames to timetable table components ([ed2a006](opentripplanner@ed2a006))
…losed-stops Timetable: add closed stops
# [@opentripplanner/timetable-v1.1.0](https://github.com/opentripplanner/otp-ui/compare/@opentripplanner/timetable-v1.0.1...@opentripplanner/timetable-v1.1.0) (2026-06-26) ### Features * Add closed stops functionality ([e602f52](opentripplanner@e602f52))
…ling Basic infrastructure to prepare for strict mode updates
…e deps - Set TS compile target to es2020 - Remove dep hoisting, add pnpm-workspace.yaml config - Add missing type dependencies to packages without strict-mode branches - Fix husky setup
- Enable TypeScript strict mode - Add TransitiveSegment type to @opentripplanner/types - Make stop_name optional in TransitiveStop - Add missing type dependencies
daniel-heppner-ibigroup
force-pushed
the
strict-mode-transitive-overlay
branch
from
July 1, 2026 20:02
7aa3287 to
f626c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables TS strict mode and then fixes the related type issues.
This PR also touches types package to create a new TransitiveSegment type which we then use in this package.