IBX-11971: Fixed keyword field criterion from matching against archived versions#765
IBX-11971: Fixed keyword field criterion from matching against archived versions#765Sztig wants to merge 2 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Integration test is mandatory to show the behavior change.
| 'ezkeyword_attribute_link', | ||
| 'kwd_lnk', | ||
| 'f_def.id = kwd_lnk.objectattribute_id' | ||
| 'f_def.id = kwd_lnk.objectattribute_id AND kwd_lnk.version = f_def.version' |
There was a problem hiding this comment.
Is f_def an alias for ezcontentobject_attribute or ezcontentclass_attribute.version? I see I made this painful for myself by choosing the same alias for both tables across the system ;)
There was a problem hiding this comment.
It's an alias for ezcontentobject_attribute
| $matcher = new HostElement(2); | ||
| // Set request and invoke match to initialize HostElement::$hostElements | ||
| $matcher->setRequest(SimplifiedRequest::fromUrl('http://ibexa.dev/foo/bar')); | ||
| // @phpstan-ignore method.resultUnused |
There was a problem hiding this comment.
Please test this in ./tests/integration using RepositoryTestCase as a base. These are legacy tests that are running on SQLite only, skipping MySQL and PostgreSQL.
For the described use case it should be straightforward to write a series of API calls that lead to wrong results.
Sztig
force-pushed
the
IBX-11971-ezkeyword-legacy-search-fix
branch
from
faf019e to
e40d0c6
Compare
|
6 participants
Description:
As title says, I have added additional check on version so we are not searching on the content that might have be archived.
For QA:
Documentation: