feat(omnipartners): extend secure code list/count types for Clixray filters - #480
Merged
Merged
Conversation
…ilters Align deals secure code inputs/outputs with Clixray API updates so loyalty can drop its multi-status list workaround. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listSecureCodesByReferralPartnertypes withsearch_filter,date_start,date_end, and typedstatusvalues (ALL,CONFIRMED, etc.).creation_dateto list items and allowexpiry_dateto benull.getSecureCodeCountwith date filters (date_start,date_end,date_filter_on) and widenedstatusunion.@filterInputwhitelists anderrorMap3129 messages for both methods.Validated against
deals.clixray.io(partner531560, dealCODES_ODR_PRO_BREEDER_30_):creation_date(notts_created).date_filter_on(CREATION/UPDATE);date_typereturns error3156when combined with dates.Test plan
yarn workspace omnipartners testyarn workspace omnipartners buildstatus=ALL+search_filter+ dates; count withdate_filter_onMade with Cursor