Move sticky header out of the way so foreground touches work - #112
Open
nicotroia wants to merge 3 commits into
Open
Move sticky header out of the way so foreground touches work#112nicotroia wants to merge 3 commits into
nicotroia wants to merge 3 commits into
Conversation
christerence
approved these changes
Aug 1, 2018
flikQ
reviewed
Sep 6, 2018
|
ok found the issue, you forgot an Animated.View on the stickyheader container. |
Make parent View Animated
Author
|
@flikQ Good catch, fixed |
|
What now, will it be merged? |
maherzaidoune
approved these changes
Dec 14, 2018
maherzaidoune
left a comment
maherzaidoune
left a comment
There was a problem hiding this comment.
works fine , press detected on Foreground
|
Any update on this? This fix would really help my project. |
|
Please merge this. I'm stuck coz of this issue |
darcien
added a commit
to darcien/react-native-parallax-scroll-view
that referenced
this pull request
Apr 16, 2019
ghost
approved these changes
Jun 6, 2019
|
You are a Hero! |
takim-fortum
approved these changes
Apr 27, 2020
maherzaidoune
approved these changes
Apr 27, 2020
EliseiNicolae
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touchable items in the foreground are currently blocked when they are positioned over the sticky header.
This change animates the sticky header to move it out of the way before the user scrolls up, allowing presses to happen in that area.