Repository navigation
fix(blueprint): wait for pty drain before restarting btop - #1095
Merged
Merged
Conversation
i098
marked this pull request as ready for review
November 1, 2026 13:51
i098
commented
Nov 1, 2026
i098
left a comment
Owner
Author
There was a problem hiding this comment.
Validation passed: the no-mistakes run checked the btop.sh clear-step fix (pads clear past the pty tail slack) and the changelog fragment; all 15 checks are green at ee3c35f and main's latest run is green. The base-script CI repro could not be shown locally; accepted because remote CI on this head is the proof. No open findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1094
Summary
Main CI went red on 5e94086 (2026-10-31 21:02Z) when
tests/test_btop_launcher.pyfailed withassert 2 == 1. The launcher restarted btop on a pty nobody was reading.What changed and why
stty "$(stty -g)"fromblueprint/maintenance/btop.sh. It did not block on a full pty.Test evidence
uv run pytest tests/test_btop_launcher.py: 3 of 3 passed after the fix, and 12 of 12 under CPU load.Checklist
fix(provisions): check the digest before install.uv run pytest).uv run ruff check).--syntax-check). Not applicable: no playbook changed.launch→launch=changed=0on the second run. Not applicable: no playbook changed.changelog.d/<issue>.<type>.md(not aCHANGELOG.mdedit), or theno changeloglabel. Not applicable: CI test fix, not user-facing.