Fix Hide & Reveal settings dropped on non-deep-linked assignments - #7432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how "Hide & Reveal" (checkpoint) assignment fields are handled and submitted in the LMS frontend. The main improvements are the consistent calculation and passing of the due date as a UTC ISO string, the addition of explicit hidden fields for
checkpoint_enabledanddue_datein the form, and enhanced test coverage for these behaviors.Assignment workflow and form handling:
dueDateISO) and consistently passed through all submit paths and components, ensuring the backend always receives the correct format. [1] [2] [3] [4]FilePickerFormFieldscomponent receives new props:checkpointEnabled(boolean) anddueDate(ISO string or null), making the assignment type and due date explicit in form handling. [1] [2]Form field rendering:
checkpointEnabledis true, hidden fields forcheckpoint_enabledand (if set)due_dateare rendered in the form, ensuring these values are submitted only for the correct assignment type.Testing improvements:
checkpoint_enabledanddue_date. [1] [2]