Repository navigation
chore: drop redundant std imports from inner tests mod.rs (§6.1 outermost) - #42
Merged
Merged
Conversation
ghfind-review
Bot
added
the
review: high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type/tests/mod.rs (the outermost tests root) already imports
std::memin its std block; the inner content_type/mod.rs and http_version/mod.rs reach it through theiruse super::*;chains. The per-inner-fileuse std::mem;added in #41 was redundant and placed at the wrong level — §6.1 / check 28: a sub-mod.rs must not import std directly. fn.rs files keep the local-use removal from #41 (that was the actual check-26 fix).Local: check 26/28 = 0 violations, http-type 304 tests pass, fmt clean.