Repository navigation
chore(deps): bump hyperlane and hyperlane-core to 21.12.1 - #25
Merged
Merged
Conversation
Also drop the duplicate DATE constant from middleware/request: the 21.12.0 migration's local copy collides (E0659) with the playground header table's identical DATE (application/header/const.rs) via the two glob chains. The header table owns it now; the collision pre-existed this bump (playground HEAD failed the same way), and the now-empty const module is removed with it. Workspace check 0 errors/warnings, tests pass.
ghfind-review
Bot
added
the
review: high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same patch bump as master (PR #24), plus one playground-only fix:
error[E0659]: DATE is ambiguous(verified by checking out HEAD without these changes). The 21.12.0 migration's localmiddleware/request/const.rsDATE collides with the playgroundapplication/header/const.rsDATE (identical value"date") through the two glob chains. The header table owns the constant; the duplicate const module is removed (it held only DATE, and an emptiedpub(crate) use r#const::*;would trip clippy).Gates: workspace check 0 errors/warnings, tests pass.