fix: suppress the false alert on AWS batch logging - #56
Merged
Merged
Conversation
Code scanning alert #23 flags the per-secret error log in the AWS provider's batch fetch. The flagged value is SecretId, the name or ARN the caller asked for, and a BatchGetSecretValue Errors entry never carries a secret value. The line now carries CodeQL's suppression comment with that reason, and a new test asserts that no log record from a partial batch failure contains the secret value.
Both high advisories (CVE-2026-97687, CVE-2026-97689) and the medium GHSA-gh4c-6fx4-qh6g were published on 2026-09-30 and are fixed in urllib3 2.8.0, which pip-audit now requires. Lockfile only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL flags the per-secret error log in the AWS provider's batch fetch as clear-text logging of a secret. It isn't one. Code scanning alert #23 (py/clear-text-logging-sensitive-data) at src/scalo/secrets/providers/aws.py:645.
.get()keyed on a name containing "secret" as sensitive, and BatchGetSecretValue fills SecretId with the name or ARN the caller asked for. An Errors entry holds SecretId, ErrorCode and Message, never a SecretString.codeql[py/clear-text-logging-sensitive-data]suppression comment, with that reason, on the line above it.