fix: trim the app environment and skip blank values - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
get_app_env()in scalo-py to parity with scalo-rs, which already trims each candidate and treats a blank value as unset.get_app_env()now strips whitespace fromAPP_ENV,ENVIRONMENTandENVin turn, and falls through to the next variable when a value is empty or whitespace-only, before defaulting to"development".get_standard_env_vars()now callsget_app_env()instead of repeating the resolution logic."development".docs/core-pillars/CONFIG.mdto note the trimming and blank-as-unset behaviour.Without this,
APP_ENV=" production"(a padded value, e.g. from a shell export or a K8s manifest) resolves toproductionin scalo-rs butdevelopmentin scalo-py.