fix(go): let the govulncheck install fetch the Go toolchain it needs - #506
Merged
Merged
Conversation
On hosted runners setup-go installs the project's go.mod version and pins GOTOOLCHAIN=local. govulncheck v1.8.0 needs Go 1.26, so on any repo declaring an older go the Quality job fails at tool install (ci-test-go-app run 37084005822, go 1.22). ARC runners skip setup-go and carry a newer Go, which is why it only shows on the free-runner path. Refs #501
Contributor
Author
|
Internal-ref rehearsals on hosted ubuntu-26.04 (branch rehearse/go-tools-26, which points setup-go-tools at this change):
The plain rehearsal of f609e09 that the gate asks for is running. |
Contributor
Author
|
Gate re-run: ci-test-go-app proven (run 37086898498). The remaining line is the composite note, which the plain rehearsal can't satisfy. The internal-ref rehearsals above are the evidence for setup-go-tools: 37084850006 installs govulncheck via go1.26.8 on a go 1.22 project, and 37086445494 is green end to end on ubuntu-26.04. Merging on that, same basis as #502. |
Contributor
|
Released in v2.12.10 -- https://github.com/hyperi-io/hyperi-ci/releases/tag/v2.12.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a hosted runner setup-go installs the project's go.mod version and pins GOTOOLCHAIN=local. govulncheck v1.8.0 needs Go 1.26, so any Go repo declaring an older go fails Quality at tool install (ci-test-go-app run 37084005822). ARC skips setup-go and carries a newer Go, so only the free-runner path hits it.
One line: GOTOOLCHAIN=auto on that single go install.
Rehearsed on hosted ubuntu-26.04 (ci-test-go-app run 37084850006): Setup Go tools now logs 'switching to go1.26.8' and the pin assert passes. Quality still fails there, on a real finding: the fixture's go 1.22 stdlib carries GO-2025-3750. That's fixed in the fixture (hyperi-io/ci-test-go-app#106), and I'll re-rehearse once it lands.
Refs #501