Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def _print(
# Resolved at call time, not bound as a default: a caller that replaces
# sys.stderr (pytest's capture) must still see the message.
print(
# codeql[py/clear-text-logging-sensitive-data] callers pass a secret's key or committed default, never a minted value
f"{Path(sys.argv[0]).stem}{f' ({header})' if header else ''}: {msg}",
file=file or sys.stderr,
)
Expand Down
1 change: 1 addition & 0 deletions scripts/creds.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ def main(argv: list[str] | None = None) -> int:
is_tty=sys.stdout.isatty(), setting=os.environ.get(_SHOW_KEY, "")
)
for line in summary_lines(values=values, reveal=reveal):
# codeql[py/clear-text-logging-sensitive-data] `make creds` exists to show the admin login, on a terminal only
print(line)
if write:
path = write_summary(values=values, path=ACCESS_SUMMARY_FILE)
Expand Down
7 changes: 5 additions & 2 deletions scripts/tests/test_origins.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,11 @@ def test_the_per_surface_override_still_wins() -> None:
DFE_HYPERDX_APP_URL="http://dfe.example.test",
)

assert "http://dfe.example.test:3000" in found
assert "http://10.0.0.5:3000" not in found
assert found == [
"http://localhost:3000",
"http://127.0.0.1:3000",
"http://dfe.example.test:3000",
]


@pytest.mark.parametrize(
Expand Down
Loading