fix: say what seeds a HyperDX team, not the engine's service token - #190
Merged
Merged
Conversation
The docs and a compose comment said the engine's service token seeds the default team with its connection and sources before anyone logs in. It never did: the engine gives the service identity no ClickHouse connection, so that team stays empty. A team is seeded from the engine's answer for its members, on their first login.
HyperDX never seeds from the service token at all, so that is the reason to give, not what the engine would answer if it were asked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HyperDX section of docs/configuration.md, and the comment on DFE_HYPERDX_ENABLED in docker-compose.yml, said the engine's service token seeds the default team with its connection and sources before anyone logs in. It never did. The engine gives the service identity no ClickHouse connection, so its team (DFE_HYPERDX_TEAM) stays empty.
Checked on a local stack with the rc.14 pins: team dfe had 0 connections and 0 sources on v0.2.7, dfe-admins was seeded at the admin's login.
Refs hyperi-io/dfe-hyperdx#68