Skip to content

make init runs scripts/init.py twice on a fresh checkout #159

Description

@catinspace-au

On a fresh checkout make init runs scripts/init.py twice.

The most likely cause: the Makefile has -include .env at the top and a .env: rule that runs init.py (Makefile:262-263). GNU make remakes an included file before it runs any target, so .env gets built first, and then the init recipe (Makefile:269-271) runs init.py again.

Harmless while init.py stays idempotent, and a trap the day it does not. It also prints everything twice.

  • Make init depend on .env and drop its own init.py call, or the other way round. One path, not two.

Done when a fresh make init runs init.py once.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions