fix: set up scalo's logger in every culvert entry point - #60
Merged
Merged
Conversation
Sixteen files log through scalo's logger and no process ever called its setup. The container entrypoint and the generate-client, revoke-client and update-crl scripts all ran on loguru's bare default handler: no scalo format, no secret scrubbing, and none of the keyword fields the code logs. Each now calls scalo.logger.setup() once at the start of main(), so LOG_LEVEL, LOG_FORMAT and the CULVERT_ cascade pick the level and format. Span export stays off because culvert emits no spans. The entrypoint's healthcheck skips it, since that probe logs nothing and runs every few seconds. The unit tier swaps setup for a no-op. A real sink bound to one test's captured stderr outlived it, and loguru reported a handler error when a later test logged.
catinspace-au
added a commit
that referenced
this pull request
Oct 1, 2026
…#61) The published image's /etc/vpn/VERSION read "dev" because nothing passed the release version into the Dockerfile's ARG VERSION build arg. hyperi-ci now renders it from release.container.build_args. CULVERT_CRL_DAYS reached Easy-RSA unvalidated, so a zero, negative, or non-numeric value could break CRL regeneration silently. validate() now rejects both cases with a clear error; unset still defaults to 180. Also documents scalo.logger.setup and its four call sites in docs/scalo-reference.md, closing the Quality "no doc did" warning from #60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixteen culvert files log through scalo's logger and no process ever called its setup. So the entrypoint and every operator script ran on loguru's bare default handler: no scalo format, no secret scrubbing, no keyword fields.
entrypoint.py,generate-client,revoke-clientandupdate-crleach callscalo.logger.setup()once at the start ofmain()LOG_LEVEL,LOG_FORMATand theCULVERT_cascade, as scalo resolves themotel_tracing=Falseeverywhere, since culvert emits no spanshealthcheckskips setup: it logs nothing and runs every few secondssetupfor a no-op, or a real sink bound to one test's captured stderr outlives itBefore,
update-crlwith no PKI:After:
tests/unit/test_logger_setup.pypatchessetupwith a recorder and asserts each entry point calls it once, before its config load. Done when CI is green.