Repository navigation
Conversation
http: add root service discovery
* Merge to main (#18) * http: add root service discovery * http: advertise allowed methods * release: version packages (#20) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: explain feed procedure request design --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR updates the ChangesFeed service maintenance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The updated dependency metadata and documentation do not introduce an actionable merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
| Filename | Overview |
|---|---|
| src/app.ts | Adds root service discovery, root metrics classification, and standards-compliant Allow headers on method errors. |
| test/app.unit.test.ts | Covers the root discovery payload, root metrics label, and rejection of non-GET root requests. |
| package.json | Bumps the package to 0.1.1 and upgrades @atproto/lex to 0.3.8. |
| scripts/fix-generated-feed-defs.mjs | Generalizes documentation and failure text for the existing generated-definition workaround. |
| .changeset/calm-feeds-greet.md | Leaves a pending patch changeset for release content already incorporated into version 0.1.1 and the changelog. |
| CHANGELOG.md | Adds the 0.1.1 release entry that duplicates the still-pending changeset. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Incoming HTTP request] --> B{Path and method}
B -->|GET /| C[Return service description and XRPC endpoints]
B -->|Non-GET /| D[405 InvalidRequest with Allow: GET]
B -->|/health or /ready| E[Operational endpoint handling]
B -->|XRPC route| F[Feed procedure handling]
C --> G[Record route=root metric]
D --> G
Reviews (1): Last reviewed commit: "deps: upgrade @atproto/lex to 0.3.8 (#23..." | Re-trigger Greptile
* Merge to main (#18) * http: add root service discovery * http: advertise allowed methods * release: version packages (#20) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…-root-discovery changesets: remove consumed root discovery fragment
|



Summary by CodeRabbit
Documentation
Maintenance