Skip to content

merge dev to main - #24

Merged
Kzoeps merged 9 commits into
mainfrom
dev
Sep 11, 2026
Merged

Kzoeps merged 9 commits into
mainfrom
dev

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation

    • Updated project guidance and README content to clarify feed request body expectations and code generation references.
    • Refreshed references to the Lexicon generator without outdated version-specific details.
  • Maintenance

    • Updated the Lexicon tooling dependency to a newer compatible release.
    • Refined diagnostic guidance for generated feed definitions without changing runtime behavior.

Kzoeps and others added 6 commits September 9, 2026 20:33
* Merge to main (#18)

* http: add root service discovery

* http: advertise allowed methods

* release: version packages (#20)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* docs: explain feed procedure request design

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3fc2d50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fb29ad77-6b05-45ee-9bb1-3bd6d81a970e

📥 Commits

Reviewing files that changed from the base of the PR and between 61b2a11 and 3fc2d50.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • AGENTS.md
  • README.md
  • package.json
  • scripts/fix-generated-feed-defs.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates the @atproto/lex dependency and removes version-specific generator references. It documents the complete JSON request-body contract for feed procedures. Runtime behavior remains unchanged.

Changes

Feed service maintenance

Layer / File(s) Summary
Lex generator compatibility updates
package.json, AGENTS.md, scripts/fix-generated-feed-defs.mjs, README.md
The Lex dependency changes from ^0.3.0 to ^0.3.8. Documentation, comments, and error messages no longer reference a pinned generator version.
Feed contract documentation
README.md
The README explains the complete JSON request-body contract for feed procedures and its implications for generated clients and breaking changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 3fc2d

The updated dependency metadata and documentation do not introduce an actionable merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the stated objective to merge the dev branch into the main branch. It does not summarize the documentation and dependency updates, but it remains related to the pull re…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​atproto/​lex@​0.3.0 ⏵ 0.3.892 +20100100 +199 +1100
Updated@​atproto/​syntax@​0.7.2 ⏵ 0.7.5100 +110094 +198 +1100

View full report

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a JSON discovery response at GET /, advertises allowed methods on 405 responses, upgrades @atproto/lex to 0.3.8, updates generated-code workaround wording, and adds documentation and unit coverage.

  • Root discovery lists the two registered public XRPC procedures.
  • Request metrics now classify / under the root route.
  • Release metadata currently represents the same patch both as an already-published 0.1.1 entry and as a pending changeset.

Confidence Score: 4/5

The code changes appear sound, but the release metadata should be reconciled before merging to prevent an unintended additional patch release.

The pending changeset duplicates a patch already applied to the package version and changelog, so the release workflow can process the same change again; no behavioral defect was established in the HTTP routing changes.

Files Needing Attention: .changeset/calm-feeds-greet.md, package.json, CHANGELOG.md

Important Files Changed

Filename Overview
src/app.ts Adds root service discovery, root metrics classification, and standards-compliant Allow headers on method errors.
test/app.unit.test.ts Covers the root discovery payload, root metrics label, and rejection of non-GET root requests.
package.json Bumps the package to 0.1.1 and upgrades @atproto/lex to 0.3.8.
scripts/fix-generated-feed-defs.mjs Generalizes documentation and failure text for the existing generated-definition workaround.
.changeset/calm-feeds-greet.md Leaves a pending patch changeset for release content already incorporated into version 0.1.1 and the changelog.
CHANGELOG.md Adds the 0.1.1 release entry that duplicates the still-pending changeset.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Incoming HTTP request] --> B{Path and method}
  B -->|GET /| C[Return service description and XRPC endpoints]
  B -->|Non-GET /| D[405 InvalidRequest with Allow: GET]
  B -->|/health or /ready| E[Operational endpoint handling]
  B -->|XRPC route| F[Feed procedure handling]
  C --> G[Record route=root metric]
  D --> G
Loading

Reviews (1): Last reviewed commit: "deps: upgrade @atproto/lex to 0.3.8 (#23..." | Re-trigger Greptile

Comment thread .changeset/calm-feeds-greet.md Outdated
* Merge to main (#18)

* http: add root service discovery

* http: advertise allowed methods

* release: version packages (#20)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@railway-app
railway-app Bot temporarily deployed to hyperindex / staging September 11, 2026 04:47 Inactive
@railway-app
railway-app Bot temporarily deployed to hyperindex / staging September 11, 2026 04:57 Inactive
@sonarqubecloud

Copy link
Copy Markdown

@Kzoeps
Kzoeps merged commit 40fae5b into main Sep 11, 2026
6 checks passed

This branch was previously deployed

1 inactive deployment
hyperindex / staging — 3fc2d505 Deployed Sep 11, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant