Skip to content

fix(groups): restore the space before "if it isn't accepted" - #249

Closed
holkexyz wants to merge 1 commit into
stagingfrom
fix/transfer-note-spacing
Closed

holkexyz wants to merge 1 commit into
stagingfrom
fix/transfer-note-spacing

Conversation

@holkexyz

Copy link
Copy Markdown
Member

Follow-up to #248. The pending-transfer line rendered as:

Proposed 2026-09-17 — expires 2026-09-24if it isn't accepted.

JSX drops the space between an expression and the word after it when the two straddle a line break, so the expiry date ran into the following word — the space is present in the source, which is what makes this easy to reintroduce while reformatting.

Builds the sentence as one string in a transferPendingNote helper and pins the spacing with a unit test, following the existing pure-helper testing pattern in this component.

Also deletes the branch-recreation artifact: #248 was merged while this fix was in flight, so it lands on a fresh branch off current staging.

npx tsc --noEmit, npm run lint and the group component tests are clean.

🤖 Generated with Claude Code

The pending-transfer line read "expires 2026-09-24if it isn't
accepted": JSX drops the space between an expression and the word
after it when the two straddle a line break, so the expiry date ran
into the following word.

Build the sentence as one string in `transferPendingNote` and cover the
spacing with a unit test, so reflowing the JSX can't reintroduce it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
certified-app Ready Ready Preview Sep 17, 2026 7:34pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7e23a4f6-f68a-4cc2-be26-1a2ac35c7638

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@holkexyz

Copy link
Copy Markdown
Member Author

Landed directly on staging as ade65b3 instead.

@holkexyz holkexyz closed this Sep 17, 2026
@holkexyz
holkexyz deleted the fix/transfer-note-spacing branch September 17, 2026 19:34

This branch was successfully deployed

1 active deployment
Preview — aae06c1f Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant