Skip to content

ci: disable cancel-in-progress in CI matrix - #17

Merged
aspiers merged 1 commit into
hypercerts-org:devfrom
aspiers:cancel-in-progress
Jan 28, 2026
Merged

aspiers merged 1 commit into
hypercerts-org:devfrom
aspiers:cancel-in-progress

Conversation

@aspiers

@aspiers aspiers commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

We want to be able to see all failures at once rather than fixing one, re-running CI to see the next, fixing that, and so on which is ridiculously inefficient.

We want to be able to see all failures at once rather than fixing
one, re-running CI to see the next, fixing that, and so on which
is ridiculously inefficient.
Copilot AI review requested due to automatic review settings January 22, 2026 23:23
@vercel

vercel Bot commented Jan 22, 2026

Copy link
Copy Markdown

@aspiers is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to disable the cancellation of in-progress CI runs to view all test failures simultaneously in the matrix build. However, the implementation does not achieve this goal.

Changes:

  • Changed cancel-in-progress from true to false in the workflow's concurrency configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

concurrency:
group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}'
cancel-in-progress: true
cancel-in-progress: false

Copilot AI Jan 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to cancel-in-progress: false does not achieve the stated goal of seeing all matrix failures at once. The cancel-in-progress setting controls whether new workflow runs cancel previous runs for the same branch/PR, not whether matrix jobs within a single workflow run continue after failures.

To see all test shard failures at once (lines 46-78), you should add fail-fast: false to the test job's strategy configuration instead. By default, GitHub Actions uses fail-fast: true for matrix builds, which cancels remaining matrix jobs when one fails.

The current change will allow multiple workflow runs to execute concurrently for the same branch, which may not be the intended behavior and could waste CI resources.

Copilot uses AI. Check for mistakes.
@aspiers
aspiers merged commit 53fa62e into hypercerts-org:dev Jan 28, 2026
16 of 17 checks passed
@aspiers
aspiers deleted the cancel-in-progress branch January 28, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants