Repository navigation
ci: disable cancel-in-progress in CI matrix - #17
Conversation
We want to be able to see all failures at once rather than fixing one, re-running CI to see the next, fixing that, and so on which is ridiculously inefficient.
|
@aspiers is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR attempts to disable the cancellation of in-progress CI runs to view all test failures simultaneously in the matrix build. However, the implementation does not achieve this goal.
Changes:
- Changed
cancel-in-progressfromtruetofalsein the workflow's concurrency configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| concurrency: | ||
| group: '${{ github.workflow }}-${{ github.head_ref || github.ref }}' | ||
| cancel-in-progress: true | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
The change to cancel-in-progress: false does not achieve the stated goal of seeing all matrix failures at once. The cancel-in-progress setting controls whether new workflow runs cancel previous runs for the same branch/PR, not whether matrix jobs within a single workflow run continue after failures.
To see all test shard failures at once (lines 46-78), you should add fail-fast: false to the test job's strategy configuration instead. By default, GitHub Actions uses fail-fast: true for matrix builds, which cancels remaining matrix jobs when one fails.
The current change will allow multiple workflow runs to execute concurrently for the same branch, which may not be the intended behavior and could waste CI resources.
We want to be able to see all failures at once rather than fixing one, re-running CI to see the next, fixing that, and so on which is ridiculously inefficient.