Repository navigation
installer: report progress and reconcile ambiguous writes - #28
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e5847ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe installer now reports indexed asset-check and install progress to stderr while keeping its JSON summary on stdout. It skips parsing unused successful write responses and checks installed asset state after write errors. Tests cover progress output, read-back recovery, and interrupted response bodies. ChangesInstaller behavior
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The installer’s write-recovery behavior matches its declared-asset comparison. No merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
77e249f to
e5847ae
Compare
|
❌ The last analysis has failed. |
|
Regarding SonarCloud’s analysis comment: (reply generated by OpenAI Codex) Fixed in |
Summary
Validation
pnpm checkpnpm changeset statusgit diff --checkNo live HappyView installation was run; the write recovery test uses a local HTTP server.
Summary by CodeRabbit