Repository navigation
features: add entity feature retrieval and listing queries - #23
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 343fecf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (26)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (27)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis change adds ChangesFeature query endpoints
Badge URI validation
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant ListFeatures as listFeatures.handle()
participant PostgreSQL
Client->>ListFeatures: Send filters and pagination parameters
ListFeatures->>PostgreSQL: Query matching feature rows
PostgreSQL-->>ListFeatures: Return feature rows
ListFeatures->>PostgreSQL: Load author profile and organization records
PostgreSQL-->>ListFeatures: Return author records
ListFeatures-->>Client: Return feature views and optional cursor
Merge Risk: ⚪ Minimal · up to No identified issue blocks merging after normal checks. The HTTP test result remains pending. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 80 functions across 16 files. (10 skipped: 10 unsupported.) ✨ Finishing Touches 💡 3📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ The last analysis has failed. |
Scope
Adds public
org.hypercerts.entity.getFeatureandorg.hypercerts.entity.listFeaturesendpoints with author/type/organization filters, cursor pagination, actor sidecars, HTTP/unit coverage, and a Changeset.Validation
pnpm test:unit: 108/108 tests passed;pnpm checkandpnpm buildpassed locally.pnpm test:httpwas not run. Unit tests use local fixtures/fake adapters and do not install handlers, seed PostgreSQL, or contact HappyView. CI HTTP coverage exercises real XRPC over HTTP against the installed HappyView + PostgreSQL test environment; its result is pending from PR creation.Summary by CodeRabbit