Reject negative wait_* values at retry construction - #153
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Negative wait_initial/wait_max/wait_jitter previously reached time.sleep/asyncio.sleep and raised a cryptic "sleep length must be non-negative". Validate at _RetryContextIterator.from_params so callers get a clear ValueError naming the bad parameter. attempts/timeout=-1 left unchanged (existing tests treat them as valid).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate
wait_initial/wait_max/wait_jitterare>= 0in_RetryContextIterator.from_params.Negative values previously reached
time.sleep/asyncio.sleepand raised a crypticValueError: sleep length must be non-negative. Callers now get a clearValueErrornaming the bad parameter.attempts/timeout=-1 left unchanged (covered by existing tests).Test plan
test_negative_wait_params_rejectedpassestest_timeout_zero_warnsstill passes