test: sync qwen3 samples to pypto main#799
Draft
HecreReed wants to merge 2 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Qwen3 decode PTO kernels for both A3 and A5 targets. The generic @qwen3_decode_incore_* function names have been remapped to descriptive kernel names (such as @q_proj, @gate_proj, and @softmax) to align with the current pypto-lib/main raw kernel names. Additionally, minor adjustments were made to tile buffer allocation addresses and constants in qwen3_decode_incore_5.pto and rope_kv_cache.pto, and the README files were updated accordingly. There are no review comments provided, and I have no additional feedback on these changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings，因为 review 过程提前失败。 Log Tail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/samples/Qwen3DecodeA3andtest/samples/Qwen3DecodeA5to the currentpypto-lib/mainmodels/qwen3/32b/qwen3_32b_decode.pyoutput atccbdc4fa5cafd1eda7784c9585f9dc876791778b.ptopayloads from the latest upstream raw kernel namesValidation
a2a3anda5frompypto-lib/main.ptofiles with localptoasusing--pto-level=level3--pto-arch=a3--pto-arch=a5Scope note
DeepseekV4DecodeA3/A5pypto-lib/mainDeepSeek V4 decode flow now exports a much finer-grained kernel set than the 7 vendored PTOAS sample cases, so syncing it cleanly needs a separate sample/golden/board-validation migration instead of a straight file refresh