test(sync): guard TCI scalar-pipe vector consumer sync#772
Conversation
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings,因为 review 过程提前失败。 Log Tail |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in 'PTO_IR_manual.md' to correctly specify that the hardware mapping executes on the Scalar pipeline ('PIPE_S') instead of the Vector pipeline ('PIPE_V'). Additionally, it introduces a new lit test 'issue771_tci_vec_consumer_sync.pto' to verify synchronization behavior between the scalar pipeline and vector pipeline consumers. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
TCI -> TCVT -> TCOLEXPANDMULvector-consumer chain.pto.tcihardware mapping in the PTO IR manual fromPIPE_VtoPIPE_S.Motivation
TCIwrites must be synchronized from its actual scalar pipe before downstream vector consumers read the tile. The current main branch already modelsTCIasPIPE_S; this PR guards that behavior with the repro-shaped chain so it does not regress back to aPIPE_Vbarrier-only path.Design
pto.tci [PIPE_S]set_flag <PIPE_S -> PIPE_V>afterTCIwait_flag <PIPE_S -> PIPE_V>beforeTCVTTCOLEXPANDMULremains a vector consumerTesting
/Users/lishengtao/Documents/PTO/_codex_worktrees/fix-issue735-tci-pipe/build/tools/ptoas/ptoas --pto-arch=a3 --enable-insert-sync --pto-insert-sync-debug=2 test/lit/pto/issue771_tci_vec_consumer_sync.pto -o - 2>&1 | /Users/lishengtao/Documents/PTO/llvm-workspace/llvm-project/build-shared/bin/FileCheck test/lit/pto/issue771_tci_vec_consumer_sync.pto/Users/lishengtao/Documents/PTO/_codex_worktrees/fix-issue735-tci-pipe/build/tools/ptoas/ptoas --pto-arch=a3 --enable-insert-sync --pto-insert-sync-debug=2 test/lit/pto/issue735_tci_pipe_s_sync.pto -o - 2>&1 | /Users/lishengtao/Documents/PTO/llvm-workspace/llvm-project/build-shared/bin/FileCheck test/lit/pto/issue735_tci_pipe_s_sync.ptoninja -C build ptoasis blocked by the local LLVM/CANN dependency mismatch (SimtEntryand CANN 9.0 LLVM float type symbols missing), unrelated to this docs/test-only change.Risk / Rollback