perf: reduce per-item and global work on hot paths - #2110
Open
MathiasWP wants to merge 1 commit into
Open
Conversation
- Select/Combobox: derive item props from per-item booleans so moving the highlight or changing the value only rebuilds props for the items that actually changed instead of every mounted item - Select/Combobox (multiple): use a set for selection lookups instead of scanning the value array once per item - Calendar/RangeCalendar: resolve the local timezone once per calendar rather than once per rendered cell - Menu family: only attach the document-level `pointermove` listener while keyboard mode is active - ScrollArea/Slider/NavigationMenu: share a single `ResizeObserver` across all observed elements
🦋 Changeset detectedLatest commit: 3af44ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five contained perf fixes. No API or behavior changes.
propsreadroot.highlightedValue/root.includesItem()directly, so moving the highlight invalidated every mounted item (N prop objects + NmergeProps+ N attribute diffs per keypress). Now derived from per-item booleans, so only the two items that changed rebuild.Array.includesper item per value change; now a derivedSet.isToday(date, getLocalTimeZone())rantoday()per cell, i.e. ~42Intl.DateTimeFormat#formatToPartscalls per render. Hoisted to a root derived keyed onmonths, so it refreshes on the same cadence.documentpointermovelistener was attached for the component's whole lifetime just to flip keyboard mode off. Now attached only while keyboard mode is on.SvelteResizeObserverallocated oneResizeObserverper call site (ScrollArea makes ~6, several on the same node). Replaced with one shared observer + refcountedWeakMap.Tests: 1272 browser + 122 unit passing,
svelte-checkclean.