Repository navigation
Conversation
Settings now has two groups. App holds this page's own settings (Themes, and Daemons and Notifications once their pages exist). Daemon holds the rest, read from and written to the daemon picked above them: the one on screen by default, kept in the address as ?daemon=<name>. General, Fallback, Runtimes and Backup gain Batch apply, which sends what the page holds to each daemon ticked and says what each answered. Accounts say their secrets stay put. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Landed together in #385. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is unit 8 of the multi-daemon and notifications batch: it splits Settings and makes the daemon side of it per daemon.
data-hmz="settings-daemon").GET /api/daemons, and shows only Local when that endpoint is absent.api.daemon()when unit 6 provides it, elselocal)./d/<name>/api/..., or to plain/api/...for the daemon the page is on.?daemon=<name>, and the nav links carry it.readBackends(workspace, from)inpickers.jsandpathPicker({from})inpaths.js. So the agent, place and path pickers also read the picked daemon.data-hmz="batch-apply"). It opens a dialog of the other daemons with All, POSTs the page's payload to each daemon ticked, and shows each daemon's result: Applied, or the refusal's sentence.replace: true. Both overwrite or add, and never remove anything./* settings daemons */block.docs/user/web.mdis updated.Test plan
tests/integration/test_web_settings_daemons.pyruns in chromium and webkit. It covers the grouping, the selector scoping reads and writes,?daemon=in the address, batch apply POSTing to each daemon ticked with its result, accounts disabled, and phone width.tests/integration/test_web_*.pypasses, including the settings tests intest_web_page.py.uv run pytest tests/unitpasses.hmz webcheck: a Playwright script with routed fake daemons, screenshots at full width and at phone width.🤖 Generated with Claude Code