Repository navigation
test(web): wait for the graph to come to rest, and take ResizeObserver's notice for one - #380
Merged
Merged
Conversation
…r's notice for one The graph test measured a node at once after a drag, a wheel and Recenter, and read a session's box that a redraw may just have replaced: on a busy machine the frame that moves it comes late, and the box is None. It now waits until the node comes within the two pixels it asks, and for a box to be drawn; and it settles only once the canvas, as well as the node, has held still for a second. WebKit raises "ResizeObserver loop completed with undelivered notifications" as a page error on a busy machine. It is a notice, and no longer fails a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
futrime
force-pushed
the
test/web-page-waits
branch
from
October 12, 2026 15:06
bcedb0a to
a36fbb6
Compare
futrime
enabled auto-merge
October 12, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two causes of flakes in the browser tests, found while checking
mainfor release. Since #369 these live intests/system/web/, and this PR changes them there.test_the_graph_is_dragged_anywhere_zoomed_by_the_wheel_and_recentredread a node's centre right after a drag, a wheel and Recenter, and read a session'sbounding_box()that a redraw may have just replaced. Under load this failed withassert None,assert 22.75 < 2and similar. Before test: move the web page's browser tests to tests/system, and run the web topic in tests #369 it failed in CI too. It now polls until the node is within the 2 px it asks for (10 s at most), waits for a box to be drawn, and settles only once the canvas and the node have held still for a second.ResizeObserver loop completed with undelivered notificationsas apageerroron a busy machine. Before test: move the web page's browser tests to tests/system, and run the web topic in tests #369 this failedtest_a_runtime_is_set_up_field_by_field[webkit]in CI. It's a browser notice, soopened()no longer counts it as a page error.Test-only; no product change.
Verification
At
2 × CPUsworkers on an 18-core Mac: before the change, 2 of 6 runs of the browser topic failed; after it, 8 of 8 passed (pre-#369 layout), andtests/system/webpassed 5 of 5 after the rebase.🤖 Generated with Claude Code