Repository navigation
Fix two stale hub-kernel tests - #49795
Merged
Merged
Conversation
test_kernel_fusion pinned a revision of the dummy kernel repo whose weight renaming used \2, which rename_source_key no longer expands since #47755. Pin the repo's fixed revision, here and in test_faulty_fusion_incomplete_pattern. test_add_to_mapping_local_then_load downloaded kernels-community/layer-norm as a model repo, whose stale mirror has no build for current torch. Download it as a kernel repo, as the kernels library does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
done, copied the mocked local-kernel test from #47773 (and the revision pins already match it) |
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests in
tests/kernels/test_kernels.pyfail on main. The library code is fine; the tests are stale. Both fixes match #47773.test_kernel_fusionpins revisiond582b66ofAntonV/dummy-rmsnorm-mlp-with-transformations-and-init. That revision's weight renaming uses\2. Since Fix AI-written conversion mappings聽#47755,WeightTransform.rename_source_keyonly expands\1, sodown_proj.weightloads as missing and the logits are off. This PR pins the repo's fixed revision4a46a59, here and intest_faulty_fusion_incomplete_pattern.test_add_to_mapping_local_then_loaddownloadedkernels-community/layer-norm, whose model-type mirror has no build for current torch. It now loads a mocked kernel from a temporary local repo, as in 馃毃 Kernels=True ?!聽#47773. It no longer needs the Hub or a GPU, so it is no longer slow.How tested.
RUN_SLOW=1 pytest tests/kernels/test_kernels.py: 36 passed, 1 skipped (B200).馃 Generated with Claude Code