Repository navigation
Conversation
remi-or
added this pull request to stack #49307
October 5, 2026 04:38
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
approved these changes
Oct 5, 2026
Cyrilvallez
left a comment
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
Just one comment, feel free to disregard if you feel strongly against but IMO probably better to return None when it's not yet initialized
remi-or
force-pushed
the
add-get-recurrent
branch
4 times, most recently
from
October 19, 2026 06:05
b976353 to
9cb8375
Compare
remi-or
force-pushed
the
add-get-recurrent
branch
from
October 19, 2026 11:43
9cb8375 to
29f854f
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bamba, falcon_h1, falcon_mamba, glm5_next, granitemoehybrid, jamba, kimi_linear, mamba, mamba2, nemotron_h, olmo_hybrid, qwen3_5, qwen3_5_moe, qwen3_next, qwen4_exp, zamba |
Contributor
CI recapDashboard: View test results in Grafana |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title
Same logic as #49305 : the way we retrieve
recurrent_statesright now exposes some cache internals, that would make aPagedAttentionCachecrash and using a method is cleaner.The method checks the layer is a linear attention mixin and the recurrent state is intialized, raising with a comprehensive message if not.
BTW, it seems we only use
state_idx = 0, so it might be worth removing if we ever rework that cache.