feat: add sample count column to results table#1280
Open
SnehaDeshmukh28 wants to merge 1 commit into
Open
Conversation
Closes huggingface#804 Add a "Num. samples" column to the markdown summary table printed at the end of evaluation. The count is sourced from `effective_num_docs` already tracked per task in `config_tasks`. When `config_tasks` is absent the column is still present but left blank, preserving backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #804
What this does
Adds a "Num. samples" column to the markdown summary table printed at the end of evaluation, so users can immediately see how many samples each task was evaluated on.
Before:
| Task | Version | Metric | Value | | Stderr |
After:
| Task | Version | Num. samples | Metric | Value | | Stderr |
How it works
The count is sourced from
effective_num_docs, which is already tracked per task inconfig_tasksinside the result dict. Whenconfig_tasksis absent (e.g. older result dicts loaded from disk), the column is still present but left blank — no breaking change.Tests
Added 4 unit tests covering: