Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/rust.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
( cd kernels && cargo fmt --all -- --check )
- name: Cargo fmt (kernel-builder)
run: ( cd kernel-builder && cargo fmt --all -- --check )
- name: Cargo fmt (kernel-port)
run: ( cd kernel-port && cargo fmt --all -- --check )

clippy:
permissions:
Expand Down Expand Up @@ -62,6 +64,8 @@ jobs:
( cd kernels && cargo clippy -- -D warnings )
- name: Clippy (kernel-builder)
run: ( cd kernel-builder && cargo clippy -- -D warnings )
- name: Clippy (kernel-port)
run: ( cd kernel-port && cargo clippy -- -D warnings )

test:
permissions:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests on kernel-porter for every rust-related changes doesn't sound good to me. Maybe we should have a separate workflow for the porter and trigger it on changes specific to the porter?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I'll follow up with improved ci in the next porter changes. also lets see how long the tests take to run, if its very small it might be more simple to keep in the rust workflow (will check when merged)

Expand All @@ -86,3 +90,5 @@ jobs:
run: cargo test -p kernels-common
- name: Test (kernel-builder)
run: cargo test -p hf-kernel-builder
- name: Test (kernel-port)
run: cargo test -p kernel-port
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,6 @@ poetry.lock

# Nix
examples/kernels/**/flake.lock


kernel-port/examples
Loading
Loading