Repository navigation
feat: arch/cc compatibility check. - #774
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
commented
Aug 18, 2026
| print(f"{name}: rejected ({decision.reason})") | ||
| ``` | ||
|
|
||
| ## Device Architecture Checks |
Member
Author
There was a problem hiding this comment.
Still debating if this is the right place to include notes about it given it's supposed to be "basic" in nature. Open to suggestions.
sayakpaul
commented
Aug 18, 2026
sayakpaul
commented
Aug 18, 2026
| from kernels.compat import has_torch | ||
|
|
||
|
|
||
| def _parse_cuda_arch(arch: str) -> tuple[int, int, str] | None: |
Member
Author
There was a problem hiding this comment.
We could have used Regex here but since they can be fragile (and this is somewhat easy to parse deterministically, I thought this is better.
sayakpaul
marked this pull request as ready for review
August 18, 2026 18:08
|
Awesome, thanks! Re-tried the script I attached in #707 and it adequately crashed. |
danieldk
reviewed
Aug 19, 2026
|
|
||
| # Base and family-specific builds run on capabilities of the same | ||
| # generation with the same or a newer minor version. | ||
| return major == arch_major and minor >= arch_minor |
Member
There was a problem hiding this comment.
The +PTX suffix, which we support is not handled:
10.0+PTX: works on any capability >= 10.0.10.0a+PTX: only works on 9.0 (but embeds PTX, pretty useless, but it is supported).10.0f+PTX: works only on 10.x where x>=0 (for explicitness). Is also useful, because the runtime can JIT-compile the PTX for optimization if the capability is e.g. 10.3.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #769 and thereby should also hopefully close #707.