Skip to content

implement utils to check for kernel freshness. - #285

Merged
sayakpaul merged 16 commits into
mainfrom
utils-report-freshness
Feb 17, 2026
Merged

sayakpaul merged 16 commits into
mainfrom
utils-report-freshness

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Jan 27, 2026 •

Copy link
Copy Markdown
Member

As discussed internally.

I also took the liberty of adding a workflow to check if we always have the KERNEL_SOURCE_MAPPING updated w.r.t the kernels we maintain in the repo. LMK if I should remove it.

@sayakpaul sayakpaul changed the title feat: implement utils to check for kernel freshness. implement utils to check for kernel freshness. Jan 27, 2026
drbh
drbh previously approved these changes Jan 27, 2026

@drbh drbh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just added small nits

Comment thread scripts/check_kernel_freshness.py
Comment thread scripts/check_kernel_freshness.py Outdated
Comment thread scripts/check_kernel_freshness.py Outdated
Co-authored-by: drbh <david.richard.holtz@gmail.com>
@sayakpaul
sayakpaul requested a review from drbh January 28, 2026 10:15

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but the kernel mapping test is failing. We probably should not start with a test that immediately fails. Probably missing entries should be printed, but not lead to test failure.

It would also be nice if this test had a different name, since kernel mapping already has another meaning in the kernels ecosystem (kernel layer mapping).

Comment thread scripts/check_kernel_freshness.py Outdated


KERNEL_SOURCE_MAPPING = {
"activation": "https://github.com/vllm-project/vllm",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure about this one. Ours started diverging - we added our own functions. So, I think it's only loosely based on the vLLM version now.

@sayakpaul

Copy link
Copy Markdown
Member Author

We probably should not start with a test that immediately fails. Probably missing entries should be printed, but not lead to test failure.

My reasoning here is that when one is adding a kernel source to the repo, if it gets accidentally missed, then we might be missing out on tracking it. IMO, it's better to maintain a mapping for which we don't want to raise any error (like relu). The tests are now failing because we have a missing entry: #285 (comment). I could also add "activation" to the current mapping so that we don't have to check for its "freshness".

While reporting to our internal Slack channels, I can prepare the report such that it clearly indicates which repos haven't been synced and which repos are intentionally skipped.

Does this solution work for you?

It would also be nice if this test had a different name, since kernel mapping already has another meaning in the kernels ecosystem (kernel layer mapping).

Indeed, I will update that.

@danieldk

danieldk commented Feb 5, 2026

Copy link
Copy Markdown
Member

We probably should not start with a test that immediately fails. Probably missing entries should be printed, but not lead to test failure.

My reasoning here is that when one is adding a kernel source to the repo, if it gets accidentally missed, then we might be missing out on tracking it. IMO, it's better to maintain a mapping for which we don't want to raise any error (like relu). The tests are now failing because we have a missing entry: #285 (comment). I could also add "activation" to the current mapping so that we don't have to check for its "freshness".

While reporting to our internal Slack channels, I can prepare the report such that it clearly indicates which repos haven't been synced and which repos are intentionally skipped.

Does this solution work for you?

Thanks for the rationale! Opting out explicitly makes sense indeed.

@sayakpaul
sayakpaul requested a review from danieldk February 9, 2026 11:24
@sayakpaul

Copy link
Copy Markdown
Member Author

@danieldk I have made the changes as discussed. Additionally, if you could go through the GitHub source repos which we're using for the freshness checks, that would be helpful.

The failing test is unrelated I think?

@MekkCyber MekkCyber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice! just added some entries to the source mapping

Comment thread scripts/check_kernel_freshness.py Outdated
Comment thread scripts/check_kernel_freshness.py Outdated
sayakpaul and others added 2 commits February 12, 2026 18:57
Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
@sayakpaul
sayakpaul requested a review from MekkCyber February 12, 2026 13:30

@drbh drbh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sayakpaul

Copy link
Copy Markdown
Member Author

Failing tests seem irrelevant to me.

@sayakpaul
sayakpaul merged commit bb90d42 into main Feb 17, 2026
4 of 8 checks passed
@sayakpaul
sayakpaul deleted the utils-report-freshness branch February 17, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants