Conversation
|
This seems like a good step in the right direction. I'll look at this again later, considering merging. Unrelated: I'm wondering if we should think about supporting 3- or N-level hierarchy in the settings UI directly somehow.. it's kinda strange to go from 2 levels to the next 2 levels. Although I'm not really sure what that would look at. Maybe should look at the settings hierarchy for Android settings for example, problem is that they don't have a sidebar tab thing... Well. For later. |
I don't know whether we should remove those from the original Audio tab and add a link to the new "UI settings ->UI sound tab" instead. (I definitely don't want to add all the custom SFX selection to the original Audio tab, way too much baggage.) |
Fixes #16877, I think.
Hopefully improves #21223. @Domiiniik
AudioFileChooserfromRetroAchievementScreens.h / .cpptoMiscView.h / .cppRetroAchievementsScreen(and also the newUISettingsScreen).This isn't fully fleshed out for a release version, but I think it's good enough to be merged.
I've left a 'todo' in
UISettingsScreen.cpp.I heavily recommend renaming the string for the setting:
Transparent UI backgroundto:
Transparent pause menu backgroundbecause currently it's very vague / confusing.
Screenshots:




Tree of settings:
AI disclaimer:
AI was used to generate the skeleton of the new
UISettingsScreenclass based onDeveloperSettingsScreen, to move theAudioFileChooserclass and to help with includes (missing / redundant). No new logic was invented.