Conversation
The swipe directions only fired while the finger was actually moving, so holding a direction meant sliding around forever. Now a swiped direction stays held until the finger lifts, or until the opposite direction is swiped. Also release any held direction if the touch controls are torn down mid-gesture. Fixes #20601 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvJR8oJNSCimCM9KXVLjfq
Owner
Author
|
The result isn't really any better - if you map four swipe direction you run into problems where it's impossible to release left without also triggering right, and vice versa (and the same vertically). it's kinda unusable. I think the feature itself is not great, but it might be possible to do a better implementation. This is not it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude says
The swipe directions only fired while the finger was actually moving, so holding a direction meant sliding around forever. Now a swiped direction stays held until the finger lifts, or until the opposite direction is swiped. Also release any held direction if the touch controls are torn down mid-gesture.
Fixes #20601