Skip to content
This repository was archived by the owner on Dec 26, 2023. It is now read-only.

Fix typos etc - #6

Open
jonathan-s wants to merge 1 commit into
hotwire-django:mainfrom
jonathan-s:readthrough
Open

Fix typos etc#6
jonathan-s wants to merge 1 commit into
hotwire-django:mainfrom
jonathan-s:readthrough

Conversation

@jonathan-s

@jonathan-s jonathan-s commented Jan 3, 2021

Copy link
Copy Markdown

I had a readthrough of the repo. All in all I think it looks good, you do some clever things.

Some improvements that could possibly be made is to have settings for two things.

  • the javascript folder; in case they somehow want to name it differently; not super important as I think javascript is a pretty reasonable name.
  • be able to use yarn instead of npm. It's basically a drop-in replacement.

Those will be bundled in a single application.js file which will be copied to static/js/application.js

If I've got several django apps, will it work correctly? I assume that the stimulus command will create several application.js if you do it for several django apps. I haven't tried, but when reading through the code that's what I asked myself.

Have a watch command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant