Simplify imagery state management in ID editor - #7264
Open
sumitdahal7 wants to merge 1 commit into
Open
Conversation
… reset in editor component
|
|
cc @tyrasd (feel free to take a look at these changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What type of PR is this? (check all applicable)
Related Issue
Fixes #7255
Describe this PR
This PR refactors the imagery state management in the
iDeditor component and fixes an issue where imagery offsetspersisted between projects/tasks.
Key Changes:
customImageryIsSetlocal state. The logic now directly checks forimagery types and
iDContextavailability, making the component more predictable and easier to maintain.parameters are provided in extraIdParams. Previously, the editor would retain the offset from a previously
visited task or project, leading to incorrect alignment.
'Bing' and resets any previous custom background settings.
iDContext.background()is fully loaded before attemptingScreenshots