ci: setup frontend s3 deployment and migrate backend container registry - #518
Conversation
kshitijrajsharma
left a comment
kshitijrajsharma
left a comment
There was a problem hiding this comment.
This would be nice workflow however frontend workflow is now outdated ( kindly refer to the PR links I have attached ), Same for the renaming of the images published , optional nice to have but i think API is kinda clear already !
cc : @spwoodcock @dakotabenjamin
| context: backend/ | ||
| dockerfile: Dockerfile | ||
| image_name: ghcr.io/${{ github.repository_owner }}/fair-api | ||
| image_name: ghcr.io/${{ github.repository_owner }}/fair/backend |
There was a problem hiding this comment.
I think api is clear namespace than backend ! Optional changes ~
| context: backend/ | ||
| dockerfile: Dockerfile | ||
| image_name: ghcr.io/${{ github.repository_owner }}/fair-api | ||
| image_name: ghcr.io/${{ github.repository_owner }}/fair/backend |
There was a problem hiding this comment.
Same here ! Optional changes ~
|
if we want to rename the packages , we should rename them all to follow same convention |
|
My bad here - it was my suggestion to rename in a k8s-infra PR! I didn't realise this was the convention being used. Either is fine, I just thought instead of We do this for quite a few other tools, but its not a big deal - say whatever you think its best @kshitijrajsharma 🙏 |
No worries yes they can be removed , we can be consistent across the tools ! |
|
Merging this as production will be served by cloudfront |
3 participants
1. Backend OCI Namespace Migration
ghcr.io/hotosm/fair/backendinstead of the rootfair-apinamespace. This keeps the image properly nested under the fAIr repository and stops it from cluttering the main HOT OSM organization registry.2. Production Frontend Deployment Workflow
.github/workflows/deploy_frontend_s3.ymlto automatically build the Vite app and sync it to the new AWS production infrastructure onmainmerges.Frontend Workflow Highlights:
VITE_variables (Hanko auth, base API URLs) at build time.no-cacheonindex.html. This ensures users never get stuck on a stale version of the app.fair.hotosm.organd triggers a cache clear automatically.Note for Reviewer
This workflow pairs with the pending
k8s-infraPR. Once the admin approves and applies the AWS infrastructure changes over there, this pipeline is ready to take over the frontend deployments.