Protect the DeviceRegistry.deleted_devices container - #179720
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Protects the internal deleted-device registry while providing a deprecation path for custom integrations.
Changes:
- Adds caller-specific deprecation reporting.
- Migrates internal and test access to
_deleted_devices. - Tests core and custom integration behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/helpers/device_registry.py |
Protects the deleted-device container. |
tests/helpers/test_device_registry.py |
Updates access and adds deprecation tests. |
tests/common.py |
Updates registry test setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
arturpragacz
approved these changes
Aug 21, 2026
arturpragacz
left a comment
Member
There was a problem hiding this comment.
There are conflicts.
Other than that looks good.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Protect the
DeviceRegistry.deleted_devicescontainerUnlike #179578 which protects the
devicescontainer, there's no valid public use of the container, and all accesses toDeviceRegistry.deleted_devicesfrom core or core integrations raise and logs a warning from custom integrations.Needs #179718 +#179719
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: