Add via_device permutations to kitchen_sink - #179049
Open
emontnemery wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
force-pushed
the
child-devices
branch
from
August 13, 2026 11:11
81e4388 to
fe0573e
Compare
emontnemery
force-pushed
the
kitchen-sink-via-device
branch
from
August 14, 2026 06:24
a6db662 to
c1aa9f9
Compare
emontnemery
marked this pull request as ready for review
August 14, 2026 06:24
Contributor
There was a problem hiding this comment.
Pull request overview
Adds via_device_id relationship permutations to the kitchen sink switch platform and verifies their device-registry hierarchy.
Changes:
- Adds hub-linked switch and power-strip devices.
- Supports
via_device_idin shared device creation andDemoSwitch. - Tests via-device and child-device relationships.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/kitchen_sink/device.py |
Supports creating devices with a via-device ID. |
homeassistant/components/kitchen_sink/switch.py |
Adds hub-linked device permutations. |
tests/components/kitchen_sink/test_switch.py |
Verifies the resulting device hierarchy. |
Suppressed comments (1)
homeassistant/components/kitchen_sink/switch.py:39
- Remove this comment because it narrates the two device registrations and child entities that immediately follow.
# A second hub with a power strip linked to it via its via device; the power
# strip in turn has its own child devices (outlets).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| hass, (DOMAIN, "2_ch_power_strip"), config_entry_id=config_entry.entry_id | ||
| ) | ||
|
|
||
| # A hub with a switch device linked to it via its via device. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add via_device permutations to kitchen_sink
Draft, to be rebased after the child device PR is merged
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: